fix: address maintainer review feedback on setup-macos.sh
Fix incorrect default Claude Desktop config path — macOS uses ~/Library/Application Support/Claude/claude_desktop_config.json, not ~/.config/Claude/claude_desktop_config.json. Capture stderr in merge_config subshell (2>&1) so Python tracebacks and interpreter errors are surfaced instead of silently dropped when the command substitution fails under set -e. Update README.md and docs/PLATFORM_GUIDE.md to reflect the corrected macOS config path, and split the combined Linux/macOS config location reference into separate per-platform entries. Add trailing newline at the end.
This commit is contained in:
@@ -22,7 +22,7 @@ Options:
|
||||
--yes Do not prompt before writing (only with --apply)
|
||||
--name NAME MCP server name (default: kicad)
|
||||
--claude-config PATH Path to Claude Desktop config file
|
||||
(default: ~/.config/Claude/claude_desktop_config.json)
|
||||
(default: ~/Library/Application Support/Claude/claude_desktop_config.json)
|
||||
EOF
|
||||
}
|
||||
|
||||
@@ -96,7 +96,7 @@ done
|
||||
[[ -n "$SERVER_NAME" ]] || fail "Server name must not be empty"
|
||||
|
||||
if [[ -z "$CLAUDE_CONFIG_PATH" ]]; then
|
||||
CLAUDE_CONFIG_PATH="$HOME/.config/Claude/claude_desktop_config.json"
|
||||
CLAUDE_CONFIG_PATH="$HOME/Library/Application Support/Claude/claude_desktop_config.json"
|
||||
fi
|
||||
|
||||
case "$CLAUDE_CONFIG_PATH" in
|
||||
@@ -243,7 +243,7 @@ if [[ "$MODE" == "verify" ]]; then
|
||||
exit 0
|
||||
fi
|
||||
|
||||
MERGE_RESULT="$(merge_config)" || {
|
||||
MERGE_RESULT="$(merge_config 2>&1)" || {
|
||||
echo "$MERGE_RESULT"
|
||||
exit 1
|
||||
}
|
||||
@@ -314,4 +314,4 @@ echo " 2. Reopen Claude Desktop"
|
||||
echo " 3. In a new chat, check: + → Connectors"
|
||||
echo " 4. Verify with:"
|
||||
echo " Use the ${BOLD}$SERVER_NAME${RESET} MCP server to run ${BOLD}check_kicad_ui${RESET}."
|
||||
echo
|
||||
echo
|
||||
|
||||
Reference in New Issue
Block a user