From e28df51eb14adbc68232dba2b2a73ca9246d054f Mon Sep 17 00:00:00 2001
From: nhebling <nhebling@users.noreply.github.com>
Date: Sat, 11 Apr 2026 21:10:14 +0200
Subject: [PATCH] fix: address maintainer review feedback on setup-macos.sh
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix incorrect default Claude Desktop config path — macOS uses
~/Library/Application Support/Claude/claude_desktop_config.json,
not ~/.config/Claude/claude_desktop_config.json.

Capture stderr in merge_config subshell (2>&1) so Python tracebacks
and interpreter errors are surfaced instead of silently dropped when
the command substitution fails under set -e.

Update README.md and docs/PLATFORM_GUIDE.md to reflect the corrected
macOS config path, and split the combined Linux/macOS config location
reference into separate per-platform entries.

Add trailing newline at the end.
---
 README.md              | 5 +++--
 docs/PLATFORM_GUIDE.md | 2 +-
 setup-macos.sh         | 8 ++++----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index dc16347..cd7b3b6 100644
--- a/README.md
+++ b/README.md
@@ -613,7 +613,7 @@ Specify a custom Claude Desktop configuration file.
 Default:
 
 ```text
-~/.config/Claude/claude_desktop_config.json
+~/Library/Application Support/Claude/claude_desktop_config.json
 ```
 
 Example:
@@ -667,7 +667,8 @@ Use the kicad MCP server to run check_kicad_ui.
 
 Edit configuration file:
 
-- **Linux/macOS:** `~/.config/Claude/claude_desktop_config.json`
+- **Linux:** `~/.config/Claude/claude_desktop_config.json`
+- **macOS:** `~/Library/Application Support/Claude/claude_desktop_config.json`
 - **Windows:** `%APPDATA%\Claude\claude_desktop_config.json`
 
 **Configuration:**
diff --git a/docs/PLATFORM_GUIDE.md b/docs/PLATFORM_GUIDE.md
index 004fcfe..999bde0 100644
--- a/docs/PLATFORM_GUIDE.md
+++ b/docs/PLATFORM_GUIDE.md
@@ -483,7 +483,7 @@ bash setup-macos.sh --verify
 
 **3. Claude Config Not Picked Up**
 
-- Default path is `~/.config/Claude/claude_desktop_config.json`
+- Default path is `~/Library/Application Support/Claude/claude_desktop_config.json`
 - Use `--claude-config` flag to point to a different location
 - Fully quit and reopen Claude Desktop after changes
 
diff --git a/setup-macos.sh b/setup-macos.sh
index 3d64ca1..2d207df 100644
--- a/setup-macos.sh
+++ b/setup-macos.sh
@@ -22,7 +22,7 @@ Options:
   --yes                  Do not prompt before writing (only with --apply)
   --name NAME            MCP server name (default: kicad)
   --claude-config PATH   Path to Claude Desktop config file
-                         (default: ~/.config/Claude/claude_desktop_config.json)
+                         (default: ~/Library/Application Support/Claude/claude_desktop_config.json)
 EOF
 }
 
@@ -96,7 +96,7 @@ done
 [[ -n "$SERVER_NAME" ]] || fail "Server name must not be empty"
 
 if [[ -z "$CLAUDE_CONFIG_PATH" ]]; then
-  CLAUDE_CONFIG_PATH="$HOME/.config/Claude/claude_desktop_config.json"
+  CLAUDE_CONFIG_PATH="$HOME/Library/Application Support/Claude/claude_desktop_config.json"
 fi
 
 case "$CLAUDE_CONFIG_PATH" in
@@ -243,7 +243,7 @@ if [[ "$MODE" == "verify" ]]; then
   exit 0
 fi
 
-MERGE_RESULT="$(merge_config)" || {
+MERGE_RESULT="$(merge_config 2>&1)" || {
   echo "$MERGE_RESULT"
   exit 1
 }
@@ -314,4 +314,4 @@ echo "  2. Reopen Claude Desktop"
 echo "  3. In a new chat, check: + → Connectors"
 echo "  4. Verify with:"
 echo "     Use the ${BOLD}$SERVER_NAME${RESET} MCP server to run ${BOLD}check_kicad_ui${RESET}."
-echo
\ No newline at end of file
+echo