afcfe842cf
This commit resolves critical KiCAD 9.0 API compatibility issues identified through comprehensive testing and code audit. ## Major Fixes ### board/size.py - Board Outline Creation - **Issue:** Stub implementation didn't create actual board edges - **Fix:** Delegate to BoardOutlineCommands for proper Edge.Cuts geometry creation - **Impact:** set_board_size() now creates actual rectangular board outlines - **Tested:** 100x80mm and 4x3 inch board creation validated ### board/view.py - Board Extents Query - **Issue:** get_board_extents() command not implemented - **Fix:** New implementation returns complete bounding box data - **Returns:** left, top, right, bottom, width, height, center coordinates - **Tested:** Successfully returns 93.55mm × 212.05mm for test board ### board/__init__.py - Delegation Wiring - **Fix:** Added get_board_extents() delegation to BoardViewCommands - **Impact:** Completes board query API surface ### export.py - 3D Model Export - **Issue:** Get3DViewer() doesn't work in headless KiCAD 9.0 - **Fix:** Replace with kicad-cli subprocess calls for STEP/VRML export - **New:** _find_kicad_cli() helper for cross-platform CLI detection - **Features:** - STEP export with component/copper/silkscreen/soldermask options - VRML export with configurable units - 5-minute timeout for large boards - Proper error handling and validation - **Tested:** - STEP export: 144.65 MB (full), 114.61 MB (board-only) - VRML export: 60.69 MB - All exports successful on 415-component board ## Test Results All changes validated with test_kicad_9_fixes.py: - ✅ Board outline creation (mm and inch units) - ✅ Board extents query - ✅ STEP 3D export (full and board-only) - ✅ VRML 3D export - ✅ Error handling and validation ## Compatibility - **KiCAD Version:** 9.0.6 (tested) - **Backward Compatible:** Yes (kicad-cli available in KiCAD 8.0+) - **Platform:** Windows, macOS, Linux ## Breaking Changes None - all changes are additions or fixes to broken functionality. ## Related - Complements previous fixes: design_rules.py, component.py, layers.py - Part of comprehensive KiCAD 9.0 compatibility effort - Documentation: PYTHON_AUDIT_REPORT_FINAL.md, TEST_RESULTS.md Fixes #<issue-number-if-applicable>
74 lines
2.5 KiB
Python
74 lines
2.5 KiB
Python
"""
|
|
Board size command implementations for KiCAD interface
|
|
"""
|
|
|
|
import pcbnew
|
|
import logging
|
|
from typing import Dict, Any, Optional
|
|
|
|
logger = logging.getLogger('kicad_interface')
|
|
|
|
class BoardSizeCommands:
|
|
"""Handles board size operations"""
|
|
|
|
def __init__(self, board: Optional[pcbnew.BOARD] = None):
|
|
"""Initialize with optional board instance"""
|
|
self.board = board
|
|
|
|
def set_board_size(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Set the size of the PCB board by creating edge cuts outline"""
|
|
try:
|
|
if not self.board:
|
|
return {
|
|
"success": False,
|
|
"message": "No board is loaded",
|
|
"errorDetails": "Load or create a board first"
|
|
}
|
|
|
|
width = params.get("width")
|
|
height = params.get("height")
|
|
unit = params.get("unit", "mm")
|
|
|
|
if width is None or height is None:
|
|
return {
|
|
"success": False,
|
|
"message": "Missing dimensions",
|
|
"errorDetails": "Both width and height are required"
|
|
}
|
|
|
|
# Create board outline using BoardOutlineCommands
|
|
# This properly creates edge cuts on Edge.Cuts layer
|
|
from commands.board.outline import BoardOutlineCommands
|
|
outline_commands = BoardOutlineCommands(self.board)
|
|
|
|
# Create rectangular outline centered at origin
|
|
result = outline_commands.add_board_outline({
|
|
"shape": "rectangle",
|
|
"centerX": width / 2, # Center X
|
|
"centerY": height / 2, # Center Y
|
|
"width": width,
|
|
"height": height,
|
|
"unit": unit
|
|
})
|
|
|
|
if result.get("success"):
|
|
return {
|
|
"success": True,
|
|
"message": f"Created board outline: {width}x{height} {unit}",
|
|
"size": {
|
|
"width": width,
|
|
"height": height,
|
|
"unit": unit
|
|
}
|
|
}
|
|
else:
|
|
return result
|
|
|
|
except Exception as e:
|
|
logger.error(f"Error setting board size: {str(e)}")
|
|
return {
|
|
"success": False,
|
|
"message": "Failed to set board size",
|
|
"errorDetails": str(e)
|
|
}
|