afcfe842cf
This commit resolves critical KiCAD 9.0 API compatibility issues identified through comprehensive testing and code audit. ## Major Fixes ### board/size.py - Board Outline Creation - **Issue:** Stub implementation didn't create actual board edges - **Fix:** Delegate to BoardOutlineCommands for proper Edge.Cuts geometry creation - **Impact:** set_board_size() now creates actual rectangular board outlines - **Tested:** 100x80mm and 4x3 inch board creation validated ### board/view.py - Board Extents Query - **Issue:** get_board_extents() command not implemented - **Fix:** New implementation returns complete bounding box data - **Returns:** left, top, right, bottom, width, height, center coordinates - **Tested:** Successfully returns 93.55mm × 212.05mm for test board ### board/__init__.py - Delegation Wiring - **Fix:** Added get_board_extents() delegation to BoardViewCommands - **Impact:** Completes board query API surface ### export.py - 3D Model Export - **Issue:** Get3DViewer() doesn't work in headless KiCAD 9.0 - **Fix:** Replace with kicad-cli subprocess calls for STEP/VRML export - **New:** _find_kicad_cli() helper for cross-platform CLI detection - **Features:** - STEP export with component/copper/silkscreen/soldermask options - VRML export with configurable units - 5-minute timeout for large boards - Proper error handling and validation - **Tested:** - STEP export: 144.65 MB (full), 114.61 MB (board-only) - VRML export: 60.69 MB - All exports successful on 415-component board ## Test Results All changes validated with test_kicad_9_fixes.py: - ✅ Board outline creation (mm and inch units) - ✅ Board extents query - ✅ STEP 3D export (full and board-only) - ✅ VRML 3D export - ✅ Error handling and validation ## Compatibility - **KiCAD Version:** 9.0.6 (tested) - **Backward Compatible:** Yes (kicad-cli available in KiCAD 8.0+) - **Platform:** Windows, macOS, Linux ## Breaking Changes None - all changes are additions or fixes to broken functionality. ## Related - Complements previous fixes: design_rules.py, component.py, layers.py - Part of comprehensive KiCAD 9.0 compatibility effort - Documentation: PYTHON_AUDIT_REPORT_FINAL.md, TEST_RESULTS.md Fixes #<issue-number-if-applicable>
83 lines
3.3 KiB
Python
83 lines
3.3 KiB
Python
"""
|
|
Board-related command implementations for KiCAD interface
|
|
"""
|
|
|
|
import pcbnew
|
|
import logging
|
|
from typing import Dict, Any, Optional
|
|
|
|
# Import specialized modules
|
|
from .size import BoardSizeCommands
|
|
from .layers import BoardLayerCommands
|
|
from .outline import BoardOutlineCommands
|
|
from .view import BoardViewCommands
|
|
|
|
logger = logging.getLogger('kicad_interface')
|
|
|
|
class BoardCommands:
|
|
"""Handles board-related KiCAD operations"""
|
|
|
|
def __init__(self, board: Optional[pcbnew.BOARD] = None):
|
|
"""Initialize with optional board instance"""
|
|
self.board = board
|
|
|
|
# Initialize specialized command classes
|
|
self.size_commands = BoardSizeCommands(board)
|
|
self.layer_commands = BoardLayerCommands(board)
|
|
self.outline_commands = BoardOutlineCommands(board)
|
|
self.view_commands = BoardViewCommands(board)
|
|
|
|
# Delegate board size commands
|
|
def set_board_size(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Set the size of the PCB board"""
|
|
self.size_commands.board = self.board
|
|
return self.size_commands.set_board_size(params)
|
|
|
|
# Delegate layer commands
|
|
def add_layer(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Add a new layer to the PCB"""
|
|
self.layer_commands.board = self.board
|
|
return self.layer_commands.add_layer(params)
|
|
|
|
def set_active_layer(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Set the active layer for PCB operations"""
|
|
self.layer_commands.board = self.board
|
|
return self.layer_commands.set_active_layer(params)
|
|
|
|
def get_layer_list(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Get a list of all layers in the PCB"""
|
|
self.layer_commands.board = self.board
|
|
return self.layer_commands.get_layer_list(params)
|
|
|
|
# Delegate board outline commands
|
|
def add_board_outline(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Add a board outline to the PCB"""
|
|
self.outline_commands.board = self.board
|
|
return self.outline_commands.add_board_outline(params)
|
|
|
|
def add_mounting_hole(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Add a mounting hole to the PCB"""
|
|
self.outline_commands.board = self.board
|
|
return self.outline_commands.add_mounting_hole(params)
|
|
|
|
def add_text(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Add text annotation to the PCB"""
|
|
self.outline_commands.board = self.board
|
|
return self.outline_commands.add_text(params)
|
|
|
|
# Delegate view commands
|
|
def get_board_info(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Get information about the current board"""
|
|
self.view_commands.board = self.board
|
|
return self.view_commands.get_board_info(params)
|
|
|
|
def get_board_2d_view(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Get a 2D image of the PCB"""
|
|
self.view_commands.board = self.board
|
|
return self.view_commands.get_board_2d_view(params)
|
|
|
|
def get_board_extents(self, params: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""Get the bounding box extents of the board"""
|
|
self.view_commands.board = self.board
|
|
return self.view_commands.get_board_extents(params)
|