fix: address PR review issues for schematic analysis tools
Eliminate repeated file parsing by extracting _extract_lib_symbols helper that walks already-parsed sexp_data once instead of re-reading the file per symbol via PinLocator. Support diagonal wire overlap detection using cross-product parallelism and 1D projection. Fix wire region inclusion to use AABB intersection for pass-through wires. Normalize view region coordinates. Clarify tolerance docstrings across Python, TS, and schema. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1754,7 +1754,7 @@ SCHEMATIC_TOOLS = [
|
||||
},
|
||||
"tolerance": {
|
||||
"type": "number",
|
||||
"description": "Distance in mm below which elements are considered overlapping (default: 0.5)"
|
||||
"description": "Distance threshold in mm for label proximity and wire collinearity checks. Symbol overlap uses bounding-box intersection. (default: 0.5)"
|
||||
}
|
||||
},
|
||||
"required": ["schematicPath"]
|
||||
|
||||
Reference in New Issue
Block a user