Merge pull request #110 from mixelpixx/refactor/remove-dead-list-library-symbols-stub
refactor: remove dead list_library_symbols stub in LibraryManager
This commit is contained in:
@@ -46,32 +46,10 @@ class LibraryManager:
|
|||||||
# Return both full paths and library names
|
# Return both full paths and library names
|
||||||
return {"paths": libraries, "names": library_names}
|
return {"paths": libraries, "names": library_names}
|
||||||
|
|
||||||
@staticmethod
|
|
||||||
def list_library_symbols(library_path: str) -> List[Any]:
|
|
||||||
"""List all symbols in a library"""
|
|
||||||
try:
|
|
||||||
# kicad-skip doesn't provide a direct way to simply list symbols in a library
|
|
||||||
# without loading each one. We might need to implement this using KiCAD's Python API
|
|
||||||
# directly, or by using a different approach.
|
|
||||||
# For now, this is a placeholder implementation.
|
|
||||||
|
|
||||||
# A potential approach would be to load the library file using KiCAD's Python API
|
|
||||||
# or by parsing the library file format.
|
|
||||||
# KiCAD symbol libraries are .kicad_sym files which are S-expression format
|
|
||||||
logger.warning(
|
|
||||||
f"Attempted to list symbols in library {library_path}. This requires advanced implementation."
|
|
||||||
)
|
|
||||||
return []
|
|
||||||
except Exception as e:
|
|
||||||
logger.error(f"Error listing symbols in library {library_path}: {e}")
|
|
||||||
return []
|
|
||||||
|
|
||||||
@staticmethod
|
@staticmethod
|
||||||
def get_symbol_details(library_path: str, symbol_name: str) -> Dict[str, Any]:
|
def get_symbol_details(library_path: str, symbol_name: str) -> Dict[str, Any]:
|
||||||
"""Get detailed information about a symbol"""
|
"""Get detailed information about a symbol"""
|
||||||
try:
|
try:
|
||||||
# Similar to list_library_symbols, this might require a more direct approach
|
|
||||||
# using KiCAD's Python API or by parsing the symbol library.
|
|
||||||
logger.warning(
|
logger.warning(
|
||||||
f"Attempted to get details for symbol {symbol_name} in library {library_path}. This requires advanced implementation."
|
f"Attempted to get details for symbol {symbol_name} in library {library_path}. This requires advanced implementation."
|
||||||
)
|
)
|
||||||
@@ -143,15 +121,6 @@ if __name__ == "__main__":
|
|||||||
# Example Usage (for testing)
|
# Example Usage (for testing)
|
||||||
# List available libraries
|
# List available libraries
|
||||||
libraries = LibraryManager.list_available_libraries()
|
libraries = LibraryManager.list_available_libraries()
|
||||||
if libraries["paths"]:
|
|
||||||
first_lib = libraries["paths"][0]
|
|
||||||
lib_name = libraries["names"][0]
|
|
||||||
print(f"Testing with first library: {lib_name} ({first_lib})")
|
|
||||||
|
|
||||||
# List symbols in the first library
|
|
||||||
symbols = LibraryManager.list_library_symbols(first_lib)
|
|
||||||
# This will report that it requires advanced implementation
|
|
||||||
|
|
||||||
# Get default symbol for a component type
|
# Get default symbol for a component type
|
||||||
resistor_sym = LibraryManager.get_default_symbol_for_component_type("resistor")
|
resistor_sym = LibraryManager.get_default_symbol_for_component_type("resistor")
|
||||||
print(f"Default symbol for resistor: {resistor_sym['library']}/{resistor_sym['symbol']}")
|
print(f"Default symbol for resistor: {resistor_sym['library']}/{resistor_sym['symbol']}")
|
||||||
|
|||||||
Reference in New Issue
Block a user